• _____@lemm.eeEnglish
      23·
      23 days ago

      > someone nitpicks word you used in a variable declaration

      > you change it

      > someone more senior says the former made more sense

      > this goes on for far longer than it should

      > eventually you get a real review from someone in your team that identified something actually needs to change

      > you change it and re request reviews

      rinse and repeat

      • projectmoon@lemm.ee
        8·
        23 days ago

        Had a team lead that kept requesting nitpicky changes, going in a FULL CIRCLE about what we should change or not, to the point that changes would take weeks to get merged. Then he had the gall to say that changes were taking too long to be merged and that we couldn’t just leave code lying around in PRs.

        Jesus fucking Christ.

        There’s a reason that team imploded…

        • Fonzie!@ttrpg.network
          4·
          22 days ago

          Had a colleague who would comment things like “add a newline here” as well as things that were fully his own preference.

          That was the only time I closed comments without replying to them or fixing them, without feeling bad.

            • Fonzie!@ttrpg.network
              1·
              22 days ago

              My point exactly! But naw, several others on the team insisted this guy policing others manually is better than putting a linter in the pipeline.

              I don’t work there anymore, this is one of the (minor) reasons.

          • zalgotext@sh.itjust.works
            2·
            21 days ago

            People need to reply to those comments with “out of scope” and a link to a new issue that will get buried in the backlog more often

      • mac@lemm.ee
        4·
        23 days ago

        Don’t forget get questioned by your manager/scrum lead as to why its taking so long to get out.

        Well, I’ve had the PR ready for 3 days and the team asked me to make changes today

      • Skullgrid@lemmy.world
        2·
        23 days ago

        you forgot the part where you have to rebase your branch and that causes merge conflicts that were resolved later but somehow still persists.